Share via

Tip for doing code reviews with TFS Shelvesets

  • Article

A common complaint when doing code reviews with TFS is that people think they have to Unshelve the shelveset to review the code. They really want to see what changed in a file that is being checked in and they can’t find a way to do it. They typically wind up unshelving the shelveset and reviewing each entire file contained in the shelveset.

 

There is actually a way to view individual files from a shelveset or to compare an edited file with another version.

 

In the Unshelve dialog box, either select the shelvest and click Details or double click the shelveset name. This will bring up the Shelveset Details form. In this form, you can:

 

  1. Double click on a file name to open it in Notepad
  2. Select a file and click one of the icons in the tool bar. There are icons which will open the file in Notepad or compare revisions of the file. For new files (i.e. those with a change status of add), the comparison icon is grayed out.
  3. Right click on a filename which will bring up a selection box. In this box, you can click View which select will open the file in Notepad or Compare and a file version with which you want to compare the file being code reviewed. For new files, you cannot select Compare because the file revisions to compare against are grayed out.

When comparing revisions of a file, the Unmodified and Latest versions are always available for files which were edited. If you have an edited version in your workspace, you can compare the changed file against your version too.

 

John D'Addamio

Comments

  • Anonymous
    July 09, 2006
    Speaking of code reviews where did VS2003 SP1 go?  It seems to have disappeared into obscurity.

  • Anonymous
    July 11, 2006
    Yes ... what happened to VS2003 SP1???  There are customers out there in hinterland that rely on and sometimes even believe promised release dates.

    It would be great to be able to switch to the latest compiler release on a whim, but it simply is not feasable if you have to move over a couple millions lines of code for a mission critical application.  Try and convince your boss that switching to VS2005 was a good idea after major portions of the application break after what should have been just a recompile.

    The folks at Microsoft need to get real because you actually have real customers using your products in real world situations that are real important.

  • Anonymous
    July 14, 2006
    RE VS2003 SP1:

    Very close to the eve of testing sign off a late bug find in the VC Runtime that we felt important to get to customers in the Service Pack. The result was a build and test reset that moves our release to the middle of August.

    Regards,
    Lee Coward
    Program Manager
    Visual Studio .NET 2003 SP1

  • Anonymous
    July 17, 2006
    Just so you folks don't get the wrong idea ... I consider VS2003 to be an oustanding product and expect VS2005 to become equally so once performance and stability issues are resolved.  

    Switching to VS2005 is on our horizon though it will be a gradual process because of the scale of our applications and the issues associated with differences in compiler behaviours between VS2003/VS2005, hence the need for continued support for VS2003.

  • Anonymous
    May 31, 2009
    PingBack from http://outdoorceilingfansite.info/story.php?id=22208

  • Anonymous
    June 01, 2009
    PingBack from http://woodtvstand.info/story.php?id=11121