How I can insert the Window Close Event in my ViewModel?

Question

How I can insert the Window Close Event in my ViewModel?

Markus Freitag 3,791

Hello,

How I can insert the Close Event in my ViewModel?

How I can access for all classes for my own Logger?

    public partial class MainWindow : Window  
    {  
        //public Logger Log;  
  
        public MainWindow()  
        {  
            InitializeComponent();  
  
            //((ViewModel)DataContext).Init();  
            //((ViewModel)DataContext).CurrentOrderNumber = "XXXXX";  
  
            //DataContext.  
            //((ViewModel)DataContext).SetLogger(Log);  
        }  
  
        private void Window_Closing(object sender, System.ComponentModel.CancelEventArgs e)  
        {  
            int z = 0;  
        }  
    }

Peter Fleischer (former MVP) 19,331 Reputation points

2020-07-15T16:46:20.597+00:00

Hi Markus, at first you should decide whether and how you want to use MVVM. If you mix MVVM with codebehind, you should keep the control in codebehind, i.e. do not have the ViewModel instance created implicitly from the resource dictionary..The Windows_Closing event can also be used via an attached behavior without codebehind. To make things easier, you can use the Interactivity dll from Nuget.

Another question is, why do you need the Windows_Closing event for? There may also be other solutions, e.g. the destructor in the ViewModel.

How I can access for all classes for my own Logger?

The easiest way is to use a singleton. I had shown a solution in this forum.
Markus Freitag 3,791 Reputation points

2020-07-15T18:06:00.113+00:00

Hello, Peter,

Can you please upload a test project with ViewModel and your logger, so I can see it.
I want to detect the WindowsClose message to delete instantiated objects. If someone clicks on the X (close, application window) I should be able to get in there.

Or ViewModel Dispose or something similar.

Thanks for your example in advance.
Markus Freitag 3,791 Reputation points

2020-07-15T18:15:04.973+00:00

Can you implement another class and show how to call logging?

Thanks a lot.
DaisyTian-1203 11,631 Reputation points

2020-07-16T06:47:29.763+00:00

When and where to call log depends on your actual needs.Why do you want to delete instantiated objects in the Window_Closing event? Did you meet any error without deleting them? By the way, you need to figure out whether you're using MVVM or CodeBehind.
Markus Freitag 3,791 Reputation points

2020-07-16T08:02:59.29+00:00
public class ViewModel : INotifyPropertyChanged { protected XDocumentClient ClientLLW; protected ManualResetEvent EvTCP_NewMessageReceivedLLW; private Client ClientMar;

With the Logger, Static, SingleTon is ok now.

*anonymous user*-3316 has helped me. I use ViewModel.

My problem is, how I dispose my object, like ClientMar, ClientLLW, when the user close the application.
Can somebody makes a sample, please?
DaisyTian-1203 11,631 Reputation points

2020-07-17T07:28:34.487+00:00

Your description of question make me confusion, could you tell more details about your Client? It is under namespace MySql.Data.MySqlClient.Memcached? Could you give me a clearly descriptopn of "how I dispose my object, like ClientMar, ClientLLW"?

Peter Fleischer (former MVP) 19,331

Hi Markus,
use singleton pattern for references to your objects and call Dispose in App.Exit:

  public partial class App : Application
  {
    protected override void OnExit(ExitEventArgs e)
    {
      Model.Instance.ClientMar.Dispose();
      Model.Instance.ClientLLW.Dispose();
      base.OnExit(e);
    }
  }

Your answer

Peter Fleischer (former MVP) 19,331 Reputation points

2020-07-15T16:46:20.597+00:00

Hi Markus, at first you should decide whether and how you want to use MVVM. If you mix MVVM with codebehind, you should keep the control in codebehind, i.e. do not have the ViewModel instance created implicitly from the resource dictionary..The Windows_Closing event can also be used via an attached behavior without codebehind. To make things easier, you can use the Interactivity dll from Nuget.

Another question is, why do you need the Windows_Closing event for? There may also be other solutions, e.g. the destructor in the ViewModel.

How I can access for all classes for my own Logger?

The easiest way is to use a singleton. I had shown a solution in this forum.
Markus Freitag 3,791 Reputation points

2020-07-15T18:06:00.113+00:00

Hello, Peter,

Can you please upload a test project with ViewModel and your logger, so I can see it.
I want to detect the WindowsClose message to delete instantiated objects. If someone clicks on the X (close, application window) I should be able to get in there.

Or ViewModel Dispose or something similar.

Thanks for your example in advance.
Markus Freitag 3,791 Reputation points

2020-07-15T18:15:04.973+00:00

Can you implement another class and show how to call logging?

Thanks a lot.
DaisyTian-1203 11,631 Reputation points

2020-07-16T06:47:29.763+00:00

When and where to call log depends on your actual needs.Why do you want to delete instantiated objects in the Window_Closing event? Did you meet any error without deleting them? By the way, you need to figure out whether you're using MVVM or CodeBehind.
Markus Freitag 3,791 Reputation points

2020-07-16T08:02:59.29+00:00

public class ViewModel : INotifyPropertyChanged { protected XDocumentClient ClientLLW; protected ManualResetEvent EvTCP_NewMessageReceivedLLW; private Client ClientMar;

With the Logger, Static, SingleTon is ok now.

*anonymous user*-3316 has helped me. I use ViewModel.

My problem is, how I dispose my object, like ClientMar, ClientLLW, when the user close the application.
Can somebody makes a sample, please?
DaisyTian-1203 11,631 Reputation points

2020-07-17T07:28:34.487+00:00

Your description of question make me confusion, could you tell more details about your Client? It is under namespace MySql.Data.MySqlClient.Memcached? Could you give me a clearly descriptopn of "how I dispose my object, like ClientMar, ClientLLW"?
Peter Fleischer (former MVP) 19,331 Reputation points

2020-07-17T07:57:37.653+00:00

Hi Markus,
use singleton pattern for references to your objects and call Dispose in App.Exit:

public partial class App : Application { protected override void OnExit(ExitEventArgs e) { Model.Instance.ClientMar.Dispose(); Model.Instance.ClientLLW.Dispose(); base.OnExit(e); } }

Share via

How I can insert the Window Close Event in my ViewModel?

Your answer