Freigeben über

code review standards...

  • Artikel

Recently I had a bunch of code to check into our source depot, but I'm told that before checking anything in, it ALWAYS must be reviewed.  So I sent an e-mail to my team asking for someone to review the code.

2 days have gone by and not a single person volunteered...which I feel is horrible.  I mean, it really doesn't take much to step up to the plate and review some code, I do it whenever I get the chance so why can't they?  So I went and talked to my boss about it.  I told him we really need to get a process in place to get code reviewed in a timely manor.  His answer was that I should just go into on of my teammates office and ask them to do it, rather than sending an e-mail.

I disagree with this method because you can't just expect people to drop whatever they are doing and review your code right then and there...so I told him this, and he pushed the question back on me...asked me how I thought we should do it.

Honestly I don't know.  I'm still pretty new to the coding game and not sure what would be the best practice for this, so I thought I'd ask here.  Anyone have some code review standards they could share?

Comments

  • Anonymous
    June 03, 2005
    Where I work, when we're done with a project it goes through two rounds of "programmer QA" (PQA) before it gets into the QA code stream. Each team lead is responsible for dividing up the projects amongst the developers for PQA, and each developer knows to reserve time to do PQA.
  • Anonymous
    June 03, 2005
    I've just been through a pair of code reviews and, luckily, had two other devs and at least one tester all looking at the code at the same time in the same room and it provoked some lively discussions :)

    If someone expects you to review their code, shouldn't they reciprocate? At least call by their office and agree a later time or date to review it.

    If all else fails, email me and I'll see if I can help you. I'm no architect though :)
  • Anonymous
    June 03, 2005
    It is my experience that communications (particularly email) addressed to any more than one person are dealt with by no-one.
  • Anonymous
    June 04, 2005
    I usually IM someone on the team and ask them if they have time for a code review. It always finds someone to step up....
  • Anonymous
    June 04, 2005
    I'm really not sure that this makes any sense. Our general rule is that code shouldn't be checked in unless it compiles (so automated nightly builds dont fail). Its then up to the employee to let the Project Manager or Lead Technical Architect know that the code is checked in and ready for review. Obviously, newer employees go through more regular and thorough code examination whereas those who have been there for a while typically have a short review by another team member or two but still go through a thorough QA process. I'm not really sure why you would want someone to not check in their code to the main repository where it can be backed up and/or accessed by anyone else. Of course, the new VSS in VS'05 allowes for code "shelving" which I could see as another solution to this problem.
  • Anonymous
    June 09, 2005
    Thanks for all the comments. It seems that everyone else goes through the same troubles with code review as my team. Hehehe.
  • Anonymous
    June 08, 2009
    PingBack from http://insomniacuresite.info/story.php?id=6088